Open anp opened 5 years ago
I'm still trying to understand the codebase so I might be wrong, but I think that side-effectful shouldn't be a thing anyway. In the README under key ideas it states, that salsa's queries behave like functions without side effects. I know that there are ways to make a query results be recomputed on every revision but I'd still argue that side-effects defeat the purpose of queries in salsa and that it's indeed a good thing that the compiler warns about it.
If I have a side-effectful query:
clippy warns me:
and if I remove the explicit unit return, salsa can't parse my query group definition:
I can ignore this clippy lint on this particular item, but it would be nice to be able to type the function signatures similarly to what I would do outside of salsa. Is there something different I should be doing?