salsa-rs / salsa

A generic framework for on-demand, incrementalized computation. Inspired by adapton, glimmer, and rustc's query system.
https://salsa-rs.netlify.app/
Apache License 2.0
2.09k stars 142 forks source link

Added destructors to inputs #475

Closed obsgolem closed 1 month ago

obsgolem commented 5 months ago

This is about the simplest way to solve this problem. Note that I do not do anything regarding making input structs non-Copy. Instead, you can handle free-after-free by using the Option return result.

I am not familiar enough with the codebase to know if this is likely to bork things elsewhere. I also don't know enough about our thread safety guarantees to be certain that the strategy of deleting each input ingredient in turn won't cause race conditions.

Resolves #345.

netlify[bot] commented 5 months ago

Deploy Preview for salsa-rs canceled.

Name Link
Latest commit a93f9a966f4a90956a1504a6a9553e8af8934b46
Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/65f528ee35abd40008fe366f
nikomatsakis commented 1 month ago

Given all the recent churn, going to close, get in touch though if you want to update!