salsa-rs / salsa

A generic framework for on-demand, incrementalized computation. Inspired by adapton, glimmer, and rustc's query system.
https://salsa-rs.netlify.app/
Apache License 2.0
2.09k stars 142 forks source link

salsa-2022: not updating version of tracked structs...or something #484

Closed nikomatsakis closed 5 months ago

nikomatsakis commented 5 months ago

I'm seeing a bug when using the latest salsa with dada-- I believe the steps to repro are:

this results in a panic that the tracked struct is outdated, but I think the problem is that the revision has not been updated when the memoized value was reused. This pattern isn't one I expect to support in the future but it should work on salsa as is. Will investigate deeper and create a repro test tomorrow! (hopefully)