salsa-rs / salsa

A generic framework for on-demand, incrementalized computation. Inspired by adapton, glimmer, and rustc's query system.
https://salsa-rs.netlify.app/
Apache License 2.0
2.09k stars 142 forks source link

Add missing `syn` feature requirement #500

Closed camelid closed 2 months ago

camelid commented 2 months ago

With the latest commit (283ccda), any project that uses Salsa hits tons of internal errors within Salsa. That's because Salsa needs syn's full feature, which was removed from the Cargo.toml as part of the Salsa 3.0 mega-PR. Because Salsa 1.0 still has the full feature in its Cargo.toml, Cargo implicitly still enables full for Salsa 2022, and thus the Salsa 2022 example projects compile fine -- even though any external code using Salsa does not.

netlify[bot] commented 2 months ago

Deploy Preview for salsa-rs canceled.

Name Link
Latest commit 19b40c377feac88f43de9146ce902b2ace550a8c
Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/66709f40948d39000877f279