Closed MichaReiser closed 1 month ago
Name | Link |
---|---|
Latest commit | 6975a47690a20ee188c05ea2ddd772bbd985378b |
Latest deploy log | https://app.netlify.com/sites/salsa-rs/deploys/669e8126dc6aa80008ff9f0f |
* Should `Id` use `f.debug_tuple` to preserve the name in the `Debug` output?
I think yes :)
* Should `DebugWithDb` continue to use `as_u32` directly or should it just call the `Id`'s `Debug` implementation (It would change the output if we decide that `Debug` should output `Id(num)`.
I like that it uses the debug impl, keep that I think.
I updated the Debug implementation to write Id({})
.
@nikomatsakis I addressed the feedback. Would you mind taking another look?
Ha, I probably need to start over. @nikomatsakis I don't mind rebasing (re-doing) if this is something we want to merge.
I'm in favor of this but needs a rebase
I'm in favor of this but needs a rebase
Done
I've often been confused by the fact that the IDs printed by
DebugWithDb
don't match with the ids printed when dumping asalsa::Id
withDebug
.This PR replaces the derived
Debug
implementation ofsalsa::Id
with a manualDebug
implementation that ensures that the IDs printed byDebug
andDebugWithdb
are consistent.Open Questions
Id
usef.debug_tuple
to preserve the name in theDebug
output?DebugWithDb
continue to useas_u32
directly or should it just call theId
'sDebug
implementation (It would change the output if we decide thatDebug
should outputId(num)
.