Closed davidbarsky closed 1 month ago
Name | Link |
---|---|
Latest commit | 86f06d8485edd3ad829a186eadb9fee91dbcf32c |
Latest deploy log | https://app.netlify.com/sites/salsa-rs/deploys/669ed7d88b1ae300082c5444 |
@davidbarsky I'm happy-ish to merge this PR (I'm a bit grumpy that we don't have a clearer standard in Rust land, but that's neither your fault nor tracing's, really) but it needs a rebase =)
@davidbarsky I'm happy-ish to merge this PR (I'm a bit grumpy that we don't have a clearer standard in Rust land, but that's neither your fault nor tracing's, really) but it needs a rebase =)
Rebased! And yeah: I think they occupy their own, slightly distinct niches at this point (particularly from an FFI perspective), but I wouldn't mind resolving those gaps.
I'm not sure if it is intentional but this log can blow up, depending on the value (in our case, it logs the entire AST :laughing:).
Should we exclude the value from the Memo
's Debug
impl?
I'm not sure if it is intentional but this log can blow up, depending on the value (in our case, it logs the entire AST 😆).
Should we exclude the value from the
Memo
'sDebug
impl?
@MichaReiser Yes, it's probably a good idea to exclude it. sorry about that!
Besides my well-known biases, rust-analyzer uses
tracing
, and given how big of a difference Salsa 3.0 it, I figured it makes sense to switch over.(We switched over a few months back in rust-analyzer's vendored fork of Salsa.)