search

salsa-rs / salsa

A generic framework for on-demand, incrementalized computation. Inspired by adapton, glimmer, and rustc's query system.
https://salsa-rs.netlify.app/
Apache License 2.0
2.09k stars 142 forks source link

Please make a release #517

Closed 0-wiz-0 closed 1 month ago

0-wiz-0 commented 1 month ago

The ruff project is using a particular commit in its Cargo.toml file because it needs features that are not in a release yet. This makes packaging ruff harder than necessary. Can you please make a new release?

MichaReiser commented 1 month ago

Ruff maintainer here. How do you run the ruff build? The salsa code isn't yet used in the ruff CLI. Can you try building ruff with cargo build --bin ruff. This should exclude the code depending on salsa.

0-wiz-0 commented 1 month ago

Oh. My bad. It is actually not used yet even in the pkgsrc build.

(I had trouble adapting pkgsrc downloads to provide the file for this one and didn't even get to the build step, which caused this bug report. Now I've just excluded salsa from ruff's Cargo.toml and it builds fine.)