search

salsa-rs / salsa

A generic framework for on-demand, incrementalized computation. Inspired by adapton, glimmer, and rustc's query system.
https://salsa-rs.netlify.app/
Apache License 2.0
2.09k stars 142 forks source link

re-enable cargo miri #520

Closed nikomatsakis closed 2 weeks ago

nikomatsakis commented 1 month ago

I disabled miri tests in #518 because concurrent-vec is not miri safe and filed https://github.com/orxfun/orx-concurrent-vec/issues/14 to track the underlying issue. We should either figure out why concurrent-vec is not miri-safe and fix it or adopt a new library (e.g., https://github.com/droundy/append-only-vec/ would meet our relatively simple needs if they land https://github.com/droundy/append-only-vec/pull/4; we could fork too).

droundy commented 1 month ago

I just released version 0.1.5 of append-only-vec with your PR included.

nikomatsakis commented 1 month ago

Thanks!

nikomatsakis commented 1 month ago

@droundy have you tested with miri, out of curiosity?

davidbarsky commented 2 weeks ago

Closing this, as miri is re-enabled.