search

salsa-rs / salsa

A generic framework for on-demand, incrementalized computation. Inspired by adapton, glimmer, and rustc's query system.
https://salsa-rs.netlify.app/
Apache License 2.0
2.13k stars 152 forks source link

Add CodSpeed Benchmarks to CI #533

Closed MichaReiser closed 3 months ago

MichaReiser commented 3 months ago

This PR is based on https://github.com/salsa-rs/salsa/pull/529

This PR adds a CI step to run the benchmarks with codspeed. This gives us a similar experience to https://github.com/astral-sh/ruff/pull/12406#issuecomment-2241067701

I don't have the necessary permissions to finish the setup myself.

  1. Add the repository to codspeed
  2. Add the access token (named CODSPEED_TOKEN)

We'll need to create a access token and add it. I don't have the necessary permissions. See

netlify[bot] commented 3 months ago

Deploy Preview for salsa-rs canceled.

Name Link
Latest commit d94e3421bd98d416dd036a040830326242f5afbc
Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/66a372938b629b00089ab3cf
nikomatsakis commented 3 months ago

Interesting, I had never heard of codspeed. Working on it!

nikomatsakis commented 3 months ago

OK, the token exists now

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 1 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

 - `many_tracked_structs` (134.7 µs)