search

salsa-rs / salsa

A generic framework for on-demand, incrementalized computation. Inspired by adapton, glimmer, and rustc's query system.
https://salsa-rs.netlify.app/
Apache License 2.0
2.1k stars 143 forks source link

Replace `orx-concurrent-vec` with `append-only-vec` #555

Closed MichaReiser closed 1 month ago

MichaReiser commented 1 month ago

An alternative to https://github.com/salsa-rs/salsa/pull/554

append-only-vec performs even better than boxcar and also helps to reduce the overall dependencies (and runs on 32bit!).

netlify[bot] commented 1 month ago

Deploy Preview for salsa-rs canceled.

Name Link
Latest commit 9fe39364e1d8384e5c1de04c06f8bad96d503bc4
Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/66b100dbdc0725000814776c
codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #555 will improve performances by 12.16%

Comparing MichaReiser:append-only-vec (9fe3936) with master (d6df21f)

Summary

⚡ 1 improvements

Benchmarks breakdown

Benchmark master MichaReiser:append-only-vec Change
⚡ many_tracked_structs 147 µs 131.1 µs +12.16%
nikomatsakis commented 1 month ago

Seems like a winner!

MichaReiser commented 1 month ago

Thanks for fixing the version. I'll merge this tomorrow unless you wanted me to address something else.

MichaReiser commented 1 month ago

Okay I can't merge this while changes are requested. @nikomatsakis would you mind having another look.