Fix query invalidation when high durability input changes

salsa-rs / salsa

A generic framework for on-demand, incrementalized computation. Inspired by adapton, glimmer, and rustc's query system.

https://salsa-rs.netlify.app/

Apache License 2.0

2.13k stars 152 forks source link

Closed MichaReiser closed 3 months ago

MichaReiser commented 3 months ago

This PR fixes a bug in Salsa where changing the value of a high durability field did not invalidate any queries with durability > LOW

I had to re-expose &mut Runtime again when calling ingredient_mut to call runtime.report_tracked_write in SetterImpl

netlify[bot] commented 3 months ago

Name	Link
Latest commit	a263dd04bac6719c8da5878c593900aa6493a94e
Latest deploy log	https://app.netlify.com/sites/salsa-rs/deploys/66b0e10074394a000828a210

codspeed-hq[bot] commented 3 months ago

_{Comparing MichaReiser:high-durability-write (a263dd0) with master (994c988)}

✅ 1 untouched benchmarks

MichaReiser commented 3 months ago

Hmm, not sure what the issue is with miri.

MichaReiser commented 3 months ago

I can't reproduce the miri failure locally but it also happens on master.