Closed MichaReiser closed 3 months ago
Name | Link |
---|---|
Latest commit | e994e7fae0e79e60820e6607522342442c7d14c3 |
Latest deploy log | https://app.netlify.com/sites/salsa-rs/deploys/66b47428e753ef0008120ed1 |
Comparing MichaReiser:reduce-tracing-verbosity
(e994e7f) with master
(05c7fbe)
✅ 1
untouched benchmarks
This PR reduces the verbosity of Salsa's tracing output.
Salsa used to include the
Memo
value in the tracing output. If the value is large (imagine a file's source text or AST), this can lead to very verbose traces.This PR introduces a new
tracing_debug
function onMemo
that omitsvalue
and only includes whether theMemo
's value isSome
orNone
.I considered chagning
Memo
'sDebug
implementation but I can see cases where it might be useful to debug print aMemo
including its value when debugging a Salsa issue.The output of
Memo.revisions
can still be long if a query has many dependencies but seeing the outputs is useful when debugging SalsaTest plan
I used a field-level tracing filter in Ruff and the Salsa output looks very manageable now.