search

salsaman / LiVES

LiVES is a feature rich application which combines elements of VJ and video editing software. The current version runs on Linux / BSD. Check_out_the_new_discussion_area https://github.com/salsaman/LiVES/discussions
http://lives-video.com
GNU General Public License v3.0
89 stars 11 forks source link

build error on Ubuntu 20.10 with glibc 2.32 #25

Closed PandaJim closed 3 years ago

PandaJim commented 3 years ago

In Ubuntu 20.10 libc6-dev has dropped /usr/include/rpc/rpc.h which causes build errors:

htmsocket.c:41:10: fatal error: rpc/rpc.h: No such file or directory
   41 | #include <rpc/rpc.h>
      |          ^~~~~~~~~~~
compilation terminated.
make[3]: *** [Makefile:610: sendOSC-htmsocket.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/<<PKGBUILDDIR>>/libOSC/sendOSC'
make[2]: *** [Makefile:798: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/libOSC'
make[1]: *** [Makefile:651: all-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 returned exit code 2
make: *** [debian/rules:7: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
salsaman commented 3 years ago

I think it should be possible to remove the line:

include <rpc/rpc.h>

from libOSC/sendOSC/htmsocket.c as it appears that the header is no longer required.

salsaman commented 3 years ago

I think probably at some point there were functions that needed it, but these have since been removed / replaced. The similar file src/htmsocket.c does not include rpc.h, and the quick test I did just now to remove it from libOSC did not produce any warnings or errors. In addition, the resutling binary, sendOSC seems to run fine after compiling with the #include removed.

So it seems like a safe bet to just remove the line altogether.

salsaman commented 3 years ago

If you can confirm that it resolves the issue then I will add it as a "release note".

PandaJim commented 3 years ago

I'm just building the package for Ubuntu, but not an editor. And build without "#include <rpc/rpc.h>" succeeded