search

salsify / ember-cli-dependency-lint

Lint your app's addon dependencies, making sure you only have one version of each.
MIT License
83 stars 8 forks source link

ignores config/dependency-lint in an addon #16

Open BryanCrotaz opened 5 years ago

BryanCrotaz commented 5 years ago

Getting version conflict issues for ember-assign-polyfill. Tried putting config in main addon and in dummy app, with no difference.

Tried both of these:

'use strict';
module.exports={
  generateTests: false
}
'use strict';
module.exports={
  allowedVersions: {
    'ember-assign-polyfill': '*'
  }
}

I still get a failing test in both versions.

ember-cli 3.7.1 ember-cli-dependency-lint: 1.1.3

scottkidder commented 5 years ago

I was able to get this working by putting the config in the dummy app. It raises a question for me though. Should this config be in the top-level config/

BryanCrotaz commented 3 years ago

A year later and it happened to me again. Luckily google brought me back here. Any thoughts on a solution?

jelhan commented 1 year ago

The config should be located in dummy app of an addon. The config is not for the addon but for the dummy app, which is used in testing. That gets clear when migrating to v2 addon format.

Other config files have been moved in the meantime as well: https://github.com/ember-cli/ember-addon-output/tree/v5.4.0/tests/dummy/config The root config folder does not even exists anymore in latest addon blueprints.