Beta ember-cli-babel versions trigger error

salsify / ember-cli-dependency-lint

Lint your app's addon dependencies, making sure you only have one version of each.

MIT License

83 stars 8 forks source link

Beta ember-cli-babel versions trigger error #5

Closed jrjohnson closed 7 years ago

jrjohnson commented 7 years ago

I'm seeing:

$ ember dependency-lint
ember-cli-babel
Allowed: *
Found: 5.2.4, 6.0.0-beta.5, 5.1.10

As https://github.com/machty/ember-maybe-import-regenerator is now requiring the beta bower version.

kturney commented 7 years ago

Just ran into this as well.

This is apparently the semver lib working as designed.

I worked around the issue with:

// config/dependency-lint.js

module.exports = {
  allowedVersions: {
    'ember-cli-babel': '* || >=6.0.0-beta.1'
  }
};

dfreeman commented 7 years ago

Ran into this about an hour ago as well. @kturney's suggestion will work as a workaround for the moment, but I'm leaning toward special-casing a version constraint of '*' within this addon to bypass semver.satisfies completely and just truly accept anything.

Seem reasonable?

kturney commented 7 years ago

@dfreeman seems reasonable to me

jrjohnson commented 7 years ago

Yes. I think should mean . Sounds good.

dfreeman commented 7 years ago

Fixed in v1.0.2 — thanks for reporting!