salsify / ember-css-modules

CSS Modules for ambitious applications
MIT License
282 stars 50 forks source link

Expanding embroider test coverage #277

Closed ef4 closed 2 years ago

ef4 commented 2 years ago

I was investigating ember-css-modules behavior in addons so I expanded the embroider-app tests to handle the case of an addon that uses ember-css-modules.

In addition to the documented limitation about keeping staticComponents off, addons that use ember-css-modules also need staticAddonTrees: false for the same reason.

This expanded test coverage will be helpful for anyone who is working on changes that would allow enabling these optimizations in the future.

dfreeman commented 2 years ago

Thank you!