search

salsify / ember-css-modules

CSS Modules for ambitious applications
MIT License
282 stars 49 forks source link

Glimmer support? #69

Open AKST opened 7 years ago

AKST commented 7 years ago

Does this library support glimmer? Maybe I've misunderstood the whole concept of glimmer, like if it's even meant be used as part of a ember app.

dfreeman commented 7 years ago

Right now the story for how addons work with the Glimmer build pipeline is still shaking out. Once that solidifies, we can begin to figure out what ember-css-modules looks like in the context of a Glimmer app.

Today we're relying on Ember's dependency injection system to associate local class names with templates, but the hope is that in the Unified Modules world (which Glimmer apps use an early version of today), we'll be able to determine that information statically and avoid the DI system completely.

AKST commented 7 years ago

Cheers, thanks for the update. Unless you plan on using this issue to track progress feel free to close it

dfreeman commented 7 years ago

đź‘Ť I'll keep it open to track for now, and may split it into finer grained issues as the work becomes clearer in the future.

t4t5 commented 7 years ago

This would be pretty awesome. I'd like to convert Ember Sparks into a pure Glimmer addon!

dfreeman commented 7 years ago

@t4t5 I've been meaning to ping you about Ember Sparks, actually. It's a super cool project, and I love the doc site!

I think, based on the how RFC talks about resolving things from addons, that the approach you're taking for allowing users to do custom theming may not work in the Unified Modules setup. The reason is that addons' components will no longer be merged into the host app's namespace, so there's no clear way for the app and addon to define parallel stylesheets the way you do for theming today.

It's definitely a use case I want to continue to support—just wanted to give you a heads up that the form factor may end up having to change with the Glimmer (and future Ember) setup.

t4t5 commented 7 years ago

@dfreeman Thanks for the heads up, and glad to hear that you like the project! :) I will probably have to rethink things a little bit before a 1.0 release.

Maybe we can create a separate issue about how addons can use ember-css-modules to ship easily customisable UI components? I really think it could be a killer feature for the Ember ecosystem, and this library is the one that's best suited for it imo.

dfreeman commented 7 years ago

Maybe we can create a separate issue about how addons can use ember-css-modules to ship easily customisable UI components?

@t4t5 Great idea. Would you mind opening an issue when you have a chance? I'd love to capture the constraints/goals you have in mind for making this as ergonomic as possible and use that as a jumping off point.