salsify / goldiloader

Just the right amount of Rails eager loading
MIT License
1.61k stars 53 forks source link

Use ActiveRecord lazy load hooks #141

Closed jturkel closed 7 months ago

jturkel commented 7 months ago

This PR defers referencing any ActiveRecord classes until the framework has been initialized to ensure the Rails.application.config.filter_parameters setting is applied properly. Unfortunately our usage of combustion makes it impossible to add automated test coverage but I've manually verified the fix using https://github.com/jturkel/rails-test-app.

Fixes #140

prime: @erikkessler1