active record patches: use Ruby 3 argument forwarding

salsify / goldiloader

Just the right amount of Rails eager loading

MIT License

1.61k stars 53 forks source link

active record patches: use Ruby 3 argument forwarding #158

Closed kyrofa closed 2 months ago

kyrofa commented 2 months ago

Today this uses Ruby 2-era argument forwarding that doesn't separate out keyword arguments in Ruby 3. This PR fixes #157 by updating the forwarding technique to be compatible with Ruby 3.

kyrofa commented 2 months ago

Any time, @jturkel :) .

Should I comment out my tests against Rails edge, or do you think you'll be able to ship a release relatively soon so I can just let my colleagues' tests fail for a bit and laugh at them?

jturkel commented 2 months ago

I'll get a 5.3.1 release out shortly

kyrofa commented 2 months ago

Thank you, sir :bow:

jturkel commented 2 months ago

@kyrofa - 5.3.1 has been released with this fix. Thanks again.