Link to referenced Rails bug in README

salsify / goldiloader

Just the right amount of Rails eager loading

MIT License

1.61k stars 53 forks source link

Link to referenced Rails bug in README #68

Closed swrobel closed 6 years ago

swrobel commented 6 years ago

Also wondering if "from" can be removed from the list for Rails 5.2+ due to this fix

coveralls commented 6 years ago

Coverage remained the same at 96.939% when pulling d7521997560a71662304535e3fafd668f6403653 on swrobel:patch-1 into 49983669cd0a02ff6c09280057011a5d4dbaad60 on salsify:master.

jturkel commented 6 years ago

The group eager loading bug appears to have been fixed by https://github.com/rails/rails/pull/29413 too 🎉 . I'll update the Rails bug and reenable automatic eager loading for these scenarios shortly.