Do not auto eager load has one associations with order - Githubissues

salsify / goldiloader

Just the right amount of Rails eager loading

MIT License

1.61k stars 53 forks source link

Do not auto eager load has one associations with order #71

Closed sobrinho closed 6 years ago

sobrinho commented 6 years ago

Since has one associations with an order clause indicates that the database may have more than one record, we can't auto eager load those.

Closes #61

coveralls commented 6 years ago

Coverage decreased (-0.04%) to 97.03% when pulling f3602d0527ec0f587dc640f913509fce82c9971d on sobrinho:master into f8fd0e8023191453f2f687e169599931f4264081 on salsify:master.

coveralls commented 6 years ago

Coverage decreased (-0.04%) to 97.03% when pulling f3602d0527ec0f587dc640f913509fce82c9971d on sobrinho:master into f8fd0e8023191453f2f687e169599931f4264081 on salsify:master.

coveralls commented 6 years ago

Coverage decreased (-0.04%) to 97.03% when pulling f3602d0527ec0f587dc640f913509fce82c9971d on sobrinho:master into f8fd0e8023191453f2f687e169599931f4264081 on salsify:master.

coveralls commented 6 years ago

Coverage decreased (-0.04%) to 97.03% when pulling f3602d0527ec0f587dc640f913509fce82c9971d on sobrinho:master into f8fd0e8023191453f2f687e169599931f4264081 on salsify:master.

coveralls commented 6 years ago

Coverage decreased (-0.04%) to 97.03% when pulling f3602d0527ec0f587dc640f913509fce82c9971d on sobrinho:master into f8fd0e8023191453f2f687e169599931f4264081 on salsify:master.

sobrinho commented 6 years ago

Coveralls is saying that the coverage reduced but the change I've made is covered! :)