search

salsita / prism

React / Redux action composition made simple http://salsita.github.io/prism/
495 stars 24 forks source link

Fixing issue #69 #72

Closed vasyl-purchel closed 7 years ago

vasyl-purchel commented 7 years ago

Issue #69 - removes extra '.' from matching.id

Inconsistency between how sagaId populated for mount and unmount actions leads to mounting sagas with Foo.Bar. while for unmount it uses Foo.Bar

Using Foo.Bar. seems wrong as delimiters should be explicit and not implicitly set on id.

dgsunesen commented 7 years ago

What is status on this? I just recently updated to newest version, in order to get custom matchers, and now I'm seeing this problem :-)

vasyl-purchel commented 7 years ago

I think they are working on major version bump, so if you wanna give it a try you can install package from my fork

tomkis commented 7 years ago

Closing because of redundancy after major version update.