search

salsita / redux-saga-rxjs

RxJS implementation of Saga pattern for redux
112 stars 5 forks source link

return `next(action)` from middleware #3

Closed mxdubois closed 8 years ago

mxdubois commented 8 years ago

Hey. I was just trying out your library and it's awesome! Great that such a simple lib can leverage all the power of rxjs.

I hit one snag, though. Your middleware breaks my dispatch pipeline, which currently returns the final dispatched action. I believe middleware should typically return next(action) instead of undefined. Is there any reason you didn't want to?

This matters for me because I inspect some meta info attached by my middleware to trace the completion of async actions but I'm sure I could work around it if you had a reason for returning undefined.

tomkis commented 8 years ago

Thanks! Will fix that.

tomkis commented 8 years ago

Fixed in 0.3.0