search

salsita / spicy-hooks

7 stars 0 forks source link

Make `core/useStateWithoutRerender` private #22

Closed goce-cz closed 4 years ago

goce-cz commented 4 years ago

As @tomkis pointed out, code of such a dangerous character as the useStateWithoutRerender might not be suitable for exporting from the package.

The hook itself shouldn't definitely be used unless wrapped in some kind of a higher level safe hook, such as our useDependantState. Making it private is starting to make sense...

Any opinions?

craig-bishell commented 4 years ago

I agree with @tomkis on this. I think unless it needs to be public (and I can't see why it would), then better to keep it internal for now.

On Fri, Oct 9, 2020 at 4:51 PM Jiří Staniševský notifications@github.com wrote:

Assigned #22 https://github.com/salsita/spicy-hooks/issues/22 to @craig-bishell https://github.com/craig-bishell.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/salsita/spicy-hooks/issues/22#event-3860537368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3TQ2SLQBZSCGQRDHT564LSJ4PQFANCNFSM4SKFUQOA .

goce-cz commented 4 years ago

OK, so unless anybody objects, let's hide it: #23