search

salt-extensions / saltext-azurerm

Salt Extension Modules for Azure Resource Manager
Apache License 2.0
7 stars 9 forks source link

fixed deploy_params and deploy_template bug #20

Closed M3GH4NN closed 1 year ago

M3GH4NN commented 1 year ago

fixed inside deployment_create_or_update function.

What does this PR do?

fixes deployment properties bug

What issues does this PR fix or reference?

Fixes: #18

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

M3GH4NN commented 1 year ago

paging @nicholasmhughes for PR review

M3GH4NN commented 1 year ago

paging @nicholasmhughes

nicholasmhughes commented 1 year ago

Ok. I give up. The Linux w/ 3.10 tests won't run because of https://github.com/saltstack/salt/issues/63621

... and the only way around it is some crazy gymnastics with --no-deps and defining our own reqs for Salt. Merging as-is.