search

salt-formulas / salt-formula-haproxy

Other
7 stars 20 forks source link

Fix the Backend status panel in Grafana #14

Closed elemoine closed 7 years ago

elemoine commented 7 years ago

This fixes the "Backend status ($service)" panel in the HAProxy dashboard. The InfluxDB query did not include a WHERE clause for the backend, and it included an unnecessary GROUP BY time clause.

The commit includes other changes because I used the format.py script for the formatting.

SwannCroiset commented 7 years ago

LGTM, in the mean time we can fix this bug by adding a fill(previous): https://bugs.launchpad.net/lma-toolchain/+bug/1554993

elemoine commented 7 years ago

in the mean time we can fix this bug by adding a fill(previous): https://bugs.launchpad.net/lma-toolchain/+bug/1554993

Removing the GROUP BY time clause is a better way to fix the problem I think. GROUP_BY time does not make too much sense here.

SwannCroiset commented 7 years ago

Removing the GROUP BY time clause is a better way to fix the problem I think. GROUP_BY time does not make too much sense here.

without group_by time you can have a bunch of data depending on the observation period!

elemoine commented 7 years ago

without group_by time you can have a bunch of data depending on the observation period!

I still use "last" as the aggregation function. So the query has just one result.

SwannCroiset commented 7 years ago

I still use "last" as the aggregation function. So the query has just one result.

nevermind :)