search

salt-formulas / salt-formula-iptables

Other
7 stars 18 forks source link

Allow custom chains to be present #12

Closed mnederlof closed 7 years ago

mnederlof commented 7 years ago

Other than the default chains like INPUT, FORWARD, OUTPUT

cloudlab-autobuild commented 7 years ago

Can one of the admins verify this patch?

fpytloun commented 7 years ago

Failing test on syntax: https://travis-ci.org/salt-formulas/salt-formula-iptables/jobs/243699857

mnederlof commented 7 years ago

no clue on how to fix latest failed build, in production i can just repeat the process a second time, and then it works...

mnederlof commented 7 years ago

@fpytloun can you help me figure out why the checks are failing right now? (because i think they are correct)

fpytloun commented 7 years ago

You need to wrap your changes with condition on LXC or Docker to skip these actions. Because they are not able to run iptables.

{%- if grains.get('virtual_subtype', None) not in ['Docker', 'LXC'] %}
mnederlof commented 7 years ago

Can one of the admins verify this patch?