search

salt-formulas / salt-formula-iptables

Other
7 stars 18 forks source link

include ipv6 functionality #2

Closed dvandok closed 7 years ago

dvandok commented 7 years ago

Hi,

as a feature request, I would like to see IPv6 support for this formula.

Cheers,

Dennis

fpytloun commented 7 years ago

I agree, that would be good and I don't think it's difficult to implement - if there will be no volunteers to add this support, I'll do this in my spare time :-)

dvandok commented 7 years ago

Great! I was going to give it a go, but there is probably more then one way to go about it. Maybe we should have a short discussion on which approach to take.

I already wrote a bcp.sls to reflect 'best current practices' for the kinds of icmp requests to generally let through for both ipv4 and ipv6; for ipv6 this is actually necessary for the proper functioning of the protocol. https://gist.github.com/dvandok/d7aebe3f03061169606f754271d2a757

dvandok commented 7 years ago

Looking at the structure I'm now leaning towards having the 'family' choice as part of each rule. It makes for more logical grouping of rules. I see that the standard chain names are the same for ipv4 and ipv6.

dvandok commented 7 years ago

This was easy. See pull request #3