salt-formulas / salt-formula-maas

Salt Formula Ubuntu MaaS
Other
6 stars 16 forks source link

Wait for attempts, attempt automatic recovery #39

Open alexandruavadanii opened 6 years ago

alexandruavadanii commented 6 years ago

This a collection of MaaS comissioning/deploy workarounds that we collected in OPNFV over the last year on a pool of diverse servers (x86_64, AArch64, different vendors/boards etc.).

I know maas.py is slowly being obsoleted, but this PR would help Fuel@OPFNV drop some ugly workarounds (e.g. [1, 2]) until maasng supports something similar to waitfor* functions.

cc @mpolenchuk

[1] https://github.com/opnfv/fuel/blob/stable/fraser/mcp/config/states/maas#L20-L66 [2] https://gerrit.opnfv.org/gerrit/gitweb?p=fuel.git;a=commitdiff;h=33ac2d8a4e1cb5383f794c88754edc0492004992#patch1

epcim commented 6 years ago

next time, please squash commits, for internal Gerrit review, I do have to sqush them on my own.

alexandruavadanii commented 6 years ago

Sure thing, I thought I was making things easier by splitting them.

alexandruavadanii commented 6 years ago

Hi, I just saw the comments in Gerrit [1], but I don't have an account there (nor do I know how to create one) to address them. [1] https://gerrit.mcp.mirantis.com/#/c/26625/

alexandruavadanii commented 6 years ago

I tried to address the comments in Gerrit in this PR, at least till I find a way to create an account in MCP Gerrit.