search

salt-formulas / salt-formula-sensu

Other
8 stars 10 forks source link

Add Pagerduty integration for Sensu #5

Closed cadeef closed 7 years ago

cadeef commented 7 years ago

This pull request provides Sensu integration with Pagerduty

cloudlab-autobuild commented 7 years ago

Can one of the admins verify this patch?

fpytloun commented 7 years ago

Oops, tests failed:

local:
    - Requisite declaration gem_sensu_pagerduty in SLS sensu.server is not formed as a single key dictionary

Can you please fix ASAP and verify with make test?

cadeef commented 7 years ago

I apologize, I'm new to Salt.

I'm having a hard time reproducing the error in my dev environment (make test returns clean). I added a commit to add the state module to the require statement for /etc/sensu/handlers/pagerduty.rb, am I on the right path?

fpytloun commented 7 years ago

Weird, make test even on my workstation returned error so you should be able to reproduce it as well. Anyway I fixed it with this commit: https://github.com/tcpcloud/salt-formula-sensu/commit/aafb9a0df197a690db2228043d1ad8e65572cf1b

cadeef commented 7 years ago

Thanks for the help. Looks like I was trying to use a new language feature that wasn't available in older versions of Salt-- https://docs.saltstack.com/en/latest/ref/states/requisites.html#omitting-state-module-in-requisites

fpytloun commented 7 years ago

Interesting, didn't know about this new feature :-) Anyway we are trying to be backward compatible with 2015.8 where possible.