search

saltbo / zpan

A self-hosted cloud disk base on the cloud storage./ 一个基于云存储的网盘系统，用于自建私人网盘或企业网盘。
https://zpan.space
GNU General Public License v3.0
1.83k stars 236 forks source link

Find a little mistake in `Makefile` #47

Closed Zwlin98 closed 3 years ago

Zwlin98 commented 3 years ago

the mod should be dep according to the CONTRIBUTING.md

codecov[bot] commented 3 years ago

Codecov Report

Merging #47 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   37.32%   37.32%           
=======================================
  Files           7        7           
  Lines         284      284           
=======================================
  Hits          106      106           
  Misses        155      155           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa461e0...c5283f1. Read the comment docs.

saltbo commented 3 years ago

Thanks for your PR, can you update the CONTRIBUTING.md?

Zwlin98 commented 3 years ago

OK, Did you mean keep the Makefile unchanged and fixd the CONTRIBUTING.md?

saltbo commented 3 years ago

Yes, and you should reset your old commits to keep one commit only

saltbo commented 3 years ago

No need to re-fork.

  1. git reset --soft HEAD~5
  2. git commit ''
  3. git push -f origin master
Zwlin98 commented 3 years ago

Sorry,I am a student and do not really know how to use git, and I also think the commits are to much, I'll learn to reset them.

Zwlin98 commented 3 years ago

No need to re-fork.

  1. git reset --soft HEAD~5
  2. git commit ''
  3. git push -f origin master

but I had delete the old fork, what should I do?

saltbo commented 3 years ago

Unfortunately, in this case you can only resubmit the PR