search

saltnpixels / seasaltpress

A simple starter theme for developers.
https://seasalt.press
16 stars 6 forks source link

Foolproof featured images #2

Open m9n opened 7 years ago

m9n commented 7 years ago

Don't know if you're interested, but I've recently built a theme which detects the aspect ratio of the featured image and chooses the most appropriate way of displaying it. So landscapes get used full-width as a header background, but something different happens if the user chooses a 4:3 or a portrait image, resulting in minimal cropping of the image.

I did this because very few of my clients have the technical know-how or image editing tools to care very much about the featured image. They tend to just throw it in and complain "WordPress is chopping the wrong bits off the image". Yeah, because a website is supposed to know what the "wrong bits" are ;)

If this is something you might like to consider integrating, I'll happily share and document my code in this issue.

saltnpixels commented 7 years ago

Interesting. I guess I can look at it.

The way it works right now on the theme, as you can see, is all featured images are full width of the header. (using object-fit: cover in css) But if you want a small image inside the header you can use the meta box for header where you can put whatever you want inside.

m9n commented 7 years ago

I'll share what I've done here, when I get a bit more time. Good point though - the fancy header options you include offer some good alternative solutions.

saltnpixels commented 7 years ago

ok. thanks. Let me know if you find any other issues!