saltstack-formulas / apache-formula

Set up and configure the Apache HTTP server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 285 forks source link

remove ng stuff #255

Closed k-hamza closed 5 years ago

k-hamza commented 5 years ago

Changes

k-hamza commented 5 years ago

@aboe76 still some work to do, but at the end it shoudn't have deprecations (if i didn't miss something)

for now it supports only rhel7/httpd 2.4

to support other systems :

... same for other systems

i think there is a discussion to have about config.sls : may be split it this way : config.sls contains common code and at the end include config-{{ grains['os_family'] }} that will manage specific system conf files : config-RedHat.sls config-Debian.sls config-Suse.sls ...

And about init.sls : put the content of init.sls in a new file pkg.sls or install.sls init.sls may contains only some includes

should these adaptations be added in this PR or in another after the merge of this one ? i am not familiar with other systems, so it may take me some time to achieve that. if you can help i wouldn't say no :-)

aboe76 commented 5 years ago

@k-hamza I have thought about it, sorry it took some time:

Would love to see suppport for other OSes in a different PR,

Splitting the config.sls, you could create a folder config in which you can have init.sls (for common stuff) and include RedHat.sls, Suse.sls, Debian.sls for each OS.

Leave the main init.sls as is for now maybe in a later PR this can be refactored.

By the way, I'm merging the current PR in the develop branch.

k-hamza commented 5 years ago

ok for config folder, (need some time to learn about the specificities of other systems) And thanks for the merge !