search

saltstack-formulas / apache-formula

Set up and configure the Apache HTTP server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 285 forks source link

Allow override of default_charset. #263

Closed ixs closed 4 years ago

ixs commented 5 years ago

The current Red Hat config allows to set DefaultCharset to a value. In certain situations it is necessary to leave it unconfigured thouguh.

Make the content optional, if the value of apache.default_charset is None, the item is skipped. Otherwise it defaults to UTF-8.

Drive-By: Make the charset also configurable on 2.2 and not just 2.4 as is currently the case.

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     Allow override of default_charset.

Powered by Pull Assistant. Last update 976c2b6 ... 976c2b6. Read the comment docs.

ixs commented 4 years ago

@baby-gnu you got the logic wrong, but you gave me an idea... thanks.

myii commented 4 years ago

Nice work, @ixs -- merged. Thanks for the review, @baby-gnu.

Modified the commit message using GitHub's squash merge feature, for semantic-release purposes:

-Allow override of default_charset.
+feat(redhat/apache-2.x.config.jinja): allow override of default_charset

As outlined in the contributing guidelines.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.40.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: