saltstack-formulas / apache-formula

Set up and configure the Apache HTTP server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 284 forks source link

fix(server-status): enable module in debian if `server_status_require… #280

Closed javierbertoli closed 4 years ago

javierbertoli commented 4 years ago

…` is set

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

server-status management was added to the formula a while ago (a3c0022d), but was not for Debian. This PR adds this.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 0.84

Best reviewed: commit by commit


Optimal code review plan (1 warning)

fix(server-status): manage module in debian
> `apache/server_status.sls` 41% changes removed in fix(server-status): ...
     test(default+modules): add modules' tests suite      fix(server-status): enable module in Debian family

Powered by Pull Assistant. Last update eafa419 ... 632802a. Read the comment docs.

myii commented 4 years ago

@javierbertoli Just noticed: all of the tests cover the families debian, redhat, fedora & suse. Only some of them cover arch (i.e. linux). So the other ones won't work on arch. We should have this consistent, right?

javierbertoli commented 4 years ago

@myii you're absolutely right. Fixed that and pushed, only a single mod_security test is missing now Arch but will try to fix that in another PR: I notice that when I wrote the mod_security module I added an extra yaml file which, now, makes no sense. I'd like to refactor the formula a little there.

myii commented 4 years ago

Merged, thanks for this @javierbertoli; appreciate the review @baby-gnu.

Just a note that matrix needs to be updated to use the new module suite added here.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.41.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: