Closed javierbertoli closed 4 years ago
Best reviewed: commit by commit
Powered by Pull Assistant. Last update eafa419 ... 632802a. Read the comment docs.
@javierbertoli Just noticed: all of the tests cover the families debian
, redhat
, fedora
& suse
. Only some of them cover arch
(i.e. linux
). So the other ones won't work on arch
. We should have this consistent, right?
@myii you're absolutely right. Fixed that and pushed, only a single mod_security
test is missing now Arch
but will try to fix that in another PR: I notice that when I wrote the mod_security
module I added an extra yaml file which, now, makes no sense. I'd like to refactor the formula a little there.
Merged, thanks for this @javierbertoli; appreciate the review @baby-gnu.
Just a note that matrix needs to be updated to use the new module
suite added here.
:tada: This PR is included in version 0.41.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
…` is set
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
server-status
management was added to the formula a while ago (a3c0022d), but was not for Debian. This PR adds this.Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context