saltstack-formulas / apache-formula

Set up and configure the Apache HTTP server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 285 forks source link

Remove own_default_vhost and debian_full from config.init. #288

Closed gaetanars closed 3 years ago

gaetanars commented 3 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

285

Describe the changes you're proposing

I think it's not necessary to run config.debian_full and config.own_default_vhost as default config states. config.debian_full seems to not had features in this formula.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

noelmcloughlin commented 3 years ago

LGTM, thanks very much for the PR. Appreciated!!!

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 1.0.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: