Fix modules enable - Githubissues

saltstack-formulas / apache-formula

Set up and configure the Apache HTTP server

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

Other

50 stars 285 forks source link

Fix modules enable #290

Closed SuperTux88 closed 3 years ago

SuperTux88 commented 3 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[x] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[ ] [docs] Documentation changes
[x] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Fix enabling modules on debian:

moddir needs to be set to /etc/apache2/mods-enabled like it was before.
the a2enmod needs to be executed unless the mod-file already exists, not onlyif (without the above fix, it was always executed, with the above fix it was executed when already enabled and not executed when the mod wasn't enabled yet).

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[ ] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 1.0.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: