search

saltstack-formulas / apache-formula

Set up and configure the Apache HTTP server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 285 forks source link

Do not pass full apache context to vhost templates. #298

Closed ixs closed 3 years ago

ixs commented 3 years ago

The full apache context variable can grow quite large if using multiple vhosts with SSL certificates. With 200 sites the apache variable is being rendered 200 times which resuls in observed renderer output of about 950MB...

state.apply will result with MemoryErrors in such cases.

This PR modifies the templating code to only use a per site context and pass a trimmed down copy of the apache context instead of the full.

Drive-By: Correct indentation for context variables. Drive-By: Remove duplicate map/apache functionality. Only use map.

noelmcloughlin commented 3 years ago

Thanks @ixs all good.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 1.1.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: