saltstack-formulas / apache-formula

Set up and configure the Apache HTTP server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 285 forks source link

fix(suse): Use correct vhostdir and sitesdir for Suse family #369

Closed faeyben closed 3 years ago

faeyben commented 3 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

The Suse family of distributions does not implement the sites-available/sites-enabled distinction and puts all vhosts into /etc/apache2/vhosts.d.

Sources:

Pillar / config required to test the proposed changes

https://gist.github.com/fniepelt/8e11ab2e8a4e56c45706591195e28cbc

Debug log showing how the proposed changes work

https://gist.github.com/fniepelt/c2cd745b9174569776cccc9613aa0196

Documentation checklist

Testing checklist

Additional context

noelmcloughlin commented 3 years ago

LGTM. Coud you do git commit --amend and change to lowercase so commitlint passes. thanks

faeyben commented 3 years ago

LGTM. Coud you do git commit --amend and change to lowercase so commitlint passes. thanks

Done, commitlint should be happy now.

noelmcloughlin commented 3 years ago

thanks for PR @fniepelt

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: