saltstack-formulas / apache-formula

Set up and configure the Apache HTTP server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 285 forks source link

fix(redhat): use correct vhostdir, sitesdir and logrotate script for redhat family #376

Closed l00d3r closed 2 years ago

l00d3r commented 2 years ago

Red hat family distributions do not implement sites-enabled nor vhosts.d directories and all virtual hosts are under /etc/httpd/conf.d

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Change osfamilymap values on redhat family to family defaults

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

l00d3r commented 2 years ago

Can I provide something more to help get this PR to be merged or why is it not getting approved?

noelmcloughlin commented 2 years ago

LGTM, thanks

noelmcloughlin commented 2 years ago

Hi @l00d3r you can selfie merge your own PR after a few days if CI is passing: https://docs.saltproject.io/en/latest/topics/development/conventions/formulas.html#get-involved-creating-new-formulas

Anyway, CI is passing so I will merge.

saltstack-formulas-travis commented 2 years ago

:tada: This PR is included in version 1.2.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: