saltstack-formulas / apache-formula

Set up and configure the Apache HTTP server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 285 forks source link

[fix] Update 00-mpm.conf.jinja for RedHat #378

Open ixs opened 2 years ago

ixs commented 2 years ago

Change mpm.conf template for RedHat family systems.

The code currently written will always expand to true as a pillar.get() call will return None in case the pillar is non existing, which is also considered defined. Fix this.

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

myii commented 2 years ago

@ixs Thanks for the PR. It would be helpful if you can adjust the commit message title to something like:

-Update 00-mpm.conf.jinja
+fix(00-mpm.conf.jinja): update RedHat template

That will enable semantic-release to work properly and allow the CI to run automatically (I've triggered it manually for now).