Open ixs opened 2 years ago
@ixs Thanks for the PR. It would be helpful if you can adjust the commit message title to something like:
-Update 00-mpm.conf.jinja
+fix(00-mpm.conf.jinja): update RedHat template
That will enable semantic-release
to work properly and allow the CI to run automatically (I've triggered it manually for now).
Change mpm.conf template for RedHat family systems.
The code currently written will always expand to true as a pillar.get() call will return None in case the pillar is non existing, which is also considered defined. Fix this.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
Pillar / config required to test the proposed changes
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context