saltstack-formulas / apache-formula

Set up and configure the Apache HTTP server
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
50 stars 285 forks source link

[BUG] ID apache-service-running in SLS apache.service.running is not a dictionary #383

Open OrangeDog opened 1 year ago

OrangeDog commented 1 year ago

If apache:manage_service_states is set to False, then the formula fails to compile.

This if block results in a dangling state id: https://github.com/saltstack-formulas/apache-formula/blob/v1.2.2/apache/service/running.sls#L14

It appears this file has been broken since it was introduced in 47818fc. The previous code in init.sls worked differently.