Open alxwr opened 5 months ago
Had this problem and these changes actually made it work properly.
Had the problem as well, this fixed it mostly. I only had to add the following change to remove the "Recursive requisite found" message for the configure modules:
diff --git a/formulas/apache/config/modules/install.sls b/formulas/apache/config/modules/install.sls
index 5bab8295..c7f4fecf 100644
--- a/formulas/apache/config/modules/install.sls
+++ b/formulas/apache/config/modules/install.sls
@@ -40,8 +40,6 @@ apache-config-modules-{{ module }}-enable:
{%- endif %}
- order: 225
- - require:
- - sls: {{ sls_config_file }}
- watch_in:
- module: apache-service-running-restart
- require_in:
Small update to my previous comment.
The state in apache/config/modules/install.sls
contains a hard order: 225
, which would order it before all other states without an order
key. This can give problems on new installed machines. Instead, the following change should fix both the "Recursive requisite" and the ordering issue:
diff --git a/apache/config/modules/install.sls b/apache/config/modules/install.sls
index 9cc5273..b85c80c 100644
--- a/apache/config/modules/install.sls
+++ b/apache/config/modules/install.sls
@@ -41,7 +41,7 @@ apache-config-modules-{{ module }}-enable:
{%- endif %}
- order: 225
- require:
- - sls: {{ sls_config_file }}
+ - file: apache-config-file-directory-moddir
- watch_in:
- module: apache-service-running-restart
- require_in:
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
–
Describe the changes you're proposing
I made this error go away: :-)
Pillar / config required to test the proposed changes
–
Debug log showing how the proposed changes work
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context