saltstack-formulas / bareos-formula

A Saltstack formula to install and configure Bareos
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
5 stars 12 forks source link

[bareos/repo] implemented documented repo_url for debian #8

Closed arthurzenika closed 6 years ago

javierbertoli commented 6 years ago

Good catch, it seems the 'documented repo_url' was documented but never implemented :smile:

@arthurlogilab, given that the structure of the URL is similar for Debian's family and for RedHat's family, how about extending this change to be useful for both families, like this:

{% set url = bareos.repo.repo_url if bareos.repo.repo_url is defined else bareos.repo.url_base + '/' + bareos.repo.version + '/' + distro %}

and then, just replacing L17 with

 - name: deb {{ url }} ./

and L28 with

 - baseurl: {{ url }}/

wdyt?

javierbertoli commented 6 years ago

@arthurlogilab did you have time to check and implement the changes I proposed in my previous comment ?

arthurzenika commented 6 years ago

@javierbertoli done, thanks for the suggestion.

javierbertoli commented 6 years ago

@arthurlogilab thanks for your work!