Change metricbeat pillar example to match default in 7.6.0 - Githubissues

saltstack-formulas / beats-formula

SaltStack formula to manage Elastic Beats platform

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

MIT License

9 stars 18 forks source link

Change metricbeat pillar example to match default in 7.6.0 #18

Closed christopherdraper closed 12 months ago

christopherdraper commented 4 years ago

PR progress checklist (to be filled in by reviewers)

[ ] Changes to documentation are appropriate (or tick if not required)
[ ] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[ ] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[x] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

Describe the changes you're proposing

We have deployed this formula in our environment using the example config in pillar.example. We ran into this message when troubleshooting modules:

Error in modules manager: modules management requires 'metricbeat.config.modules.path' setting

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

[ ] Updated the README (e.g. Available states).
[x] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

myii commented 4 years ago

@christopherdraper Thanks for the PR, apologies for the delay. Let's try to get some feedback from previous contributors to this formula. @psmiraglia, would you care to comment on this proposed change?