WIP: Add journalbeat - Githubissues

saltstack-formulas / beats-formula

SaltStack formula to manage Elastic Beats platform

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html

MIT License

9 stars 18 forks source link

WIP: Add journalbeat #5

Closed vquie closed 6 years ago

vquie commented 6 years ago

This PR adds the journalbeat. It will be downloaded from the official releases (https://github.com/mheese/journalbeat/releases) and configured just like the other beats shipper.

psmiraglia commented 6 years ago

Hi @vquiering. First of all, sorry for my late reply.

You're requesting to include a beat that, according to my knowledge, is not available within the official Elastic repository. So, we can define journalbeat as community beat.

I think community beats could be managed as follows:

beat specific files under beats/community/<beat> (e.g. beats/community/journalbeat)
a pillar key to enable/disable community beats (e.g. beats:enable_community)
beat specific pillar keys under beats:community:<beat> (e.g. beats:community:journalbeat)

beats:
  include_community: True
  ...
  community:
    journalbeat:
      ...

What do you think about that?

vquie commented 6 years ago

Hi @psmiraglia, sounds good to me, except for the pillar key to enable community beats. Since you call the state by beats.community.<beat> and you define the pillar under beats:community:<beat> I don't think it is necessary to define the extra key.

I will implement the changes next week.

vquie commented 6 years ago

Hi @psmiraglia, I just moved the journalbeat to a community subdir with all the necessary changes. Did not test this yet. This is why I renamed the PR to WIP. I will test it next week.

psmiraglia commented 6 years ago

vquie commented 6 years ago

@psmiraglia Did use a wrong source branch in this pr. Opened a new one which is fully tested.