search

saltstack-formulas / bind-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
29 stars 118 forks source link

Redhat/CentOS is broken by SELinux #108

Closed BrianSidebotham closed 6 years ago

BrianSidebotham commented 6 years ago

On CentOS/RHEL7 SELinux doesn't have permissions for the log file location selected. RHEL/CentOS default logging location for named is /var/named/data (in the original named.conf supplied in the RHEL/CentOS packaging)

type=AVC msg=audit(1535031676.458:4738): avc: denied { open } for pid=33274 comm="named" path="/var/log/named/query.log" dev="dm-3" ino=262174 scontext=system_u:system_r:named_t:s0 tcontext=system_u:object_r:var_log_t:s0 tclass=file

As logging is enabled by default the standard state is broken for CentOS7 and RHEL7 when SELinux is enforcing.

This fixes #107

javierbertoli commented 6 years ago

@BrianSidebotham would you please fix the tests, so we can merge this PR? It seems you need to add these particular cases here and here

BrianSidebotham commented 6 years ago

@javierbertoli Sure - no problem.

javierbertoli commented 6 years ago

@BrianSidebotham when tests pass, would you squash your commits, so I merge them?

BrianSidebotham commented 6 years ago

@javierbertoli Sure no problem, I can squash the commits. Sorry - you can see me scrabbling in the dark to fix things in the rb files!

javierbertoli commented 6 years ago

@BrianSidebotham no problem, thank you for taking the time to fix this. Merged!

BrianSidebotham commented 6 years ago

@javierbertoli Great thanks.