search

saltstack-formulas / bind-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
29 stars 117 forks source link

Two fixes #110

Closed bmwiedemann closed 6 years ago

bmwiedemann commented 6 years ago

only tested on SUSE OSes

javierbertoli commented 6 years ago

@bmwiedemann can you add the same |sort parameter in the other distros' files, for consistency?

bmwiedemann commented 6 years ago

@javierbertoli I had already done that.

Switched to |dictsort now as seen in https://github.com/saltstack-formulas/munin-formula/commit/0fe2f7e66b68bebaa62247f670d43affe6cb9c96 ; also looks nicer.

There are some iteritems() remaining where I'm not sure, if they need treatment.

bmwiedemann commented 6 years ago

ping. Anything left that prevents merging?

javierbertoli commented 6 years ago

@bmwiedemann sorry I missed your previous comment. I think you can replace those iteritems() too. Would you change those, and then I'll merge, if the tests pass?

bmwiedemann commented 6 years ago

Did the s/iteritems/dictsort/ However, I dont know much about iterables etc in jinja/python so doing guessing here.

javierbertoli commented 6 years ago

@bmwiedemann , thanks to the tests introduced by @ryanwalder in #105, we can be quite sure nothing broke, so merging :smile:

Thanks for your work!