search

saltstack-formulas / bind-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
29 stars 117 forks source link

feat: implement an automated changelog #129

Closed daks closed 5 years ago

daks commented 5 years ago

Before removing 'draft' status and activate only 5 builds on Travis, I wanted to test them all: Fedora and OpenSuse fails, see https://travis-ci.com/daks/bind-formula/builds/112325721. We need to see if we can/want to fix those platforms, remove them (in FORMULA, travis, kitchen, inspec) or just 'ignore' _ them.

TODO: reduce number of builds to 5 max

myii commented 5 years ago

@daks Trying to compete with @n-rodriguez to see who can do the most semantic-release PRs, eh?! Maybe we should add the contributor to the docs so that we can keep track of the numbers!

daks commented 5 years ago

@myii, not exactly, just trying to convert all formulas we use @ work :) And this conversion is generally not that much work... except when tests start failing...

myii commented 5 years ago

@daks Of course, semantic-release isn't going to work unless all of the tests are passing, so need to ensure that that is working. It may be worth rebasing to use the latest Gemfile as well.

daks commented 5 years ago

previous tests working: debian-8, debian-9, ubuntu-16.04, ubuntu-18.04, fedora-27 and centos-7 on latest salt

daks commented 5 years ago

I don't understand why those tests are failing. Provisioning (states, pillars) should be the same, and tests too

daks commented 5 years ago

I have fixed most of Suse/OpenSuse tests. The only one remaining is weird https://travis-ci.com/daks/bind-formula/jobs/202183367 -> inspec don't find 'named' service running, while it is

About Fedora, I can't fix them because they 'work on my laptop'(TM). any help would be appreciated.

javierbertoli commented 5 years ago

I have fixed most of Suse/OpenSuse tests. The only one remaining is weird https://travis-ci.com/daks/bind-formula/jobs/202183367 -> inspec don't find 'named' service running, while it is

It's quite probably the same issue due to the train gem

Perhaps you can skip it atm.

daks commented 5 years ago

@javierbertoli ok, I'll skip opensuse 15 for now.

Still Fedora failing.

myii commented 5 years ago

@daks Or you could use @n-rodriguez's fix here appended in the Gemfile:

gem 'train', git: 'https://github.com/n-rodriguez/train.git', branch: 'wip/fix_suse'
daks commented 5 years ago

Tests matrix reduced to 4 platforms

myii commented 5 years ago

@daks Do you want this merged now?

daks commented 5 years ago

If it's OK for everybody, yes.

myii commented 5 years ago

Merged, thanks for another big PR, @daks.

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 0.17.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: