Closed Irsute closed 4 years ago
@Irsute The Travis errors are unrelated to this PR, we've had a problem when using rubocop -a --safe
. I'll get around to fixing that soon and then we can rebase this PR to confirm it is working.
@Irsute I've added your commit from here in c814779, with slight amendments to pass the InSpec tests.
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
fix pillar for test (failling for named in FEDORA 30)
Primary type
[build]
Changes related to the build system[chore]
Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]
Changes to the continuous integration configuration[feat]
A new feature[fix]
A bug fix[perf]
A code change that improves performance[refactor]
A code change that neither fixes a bug nor adds a feature[revert]
A change used to revert a previous commit[style]
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]
Documentation changes[test]
Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE
?No.
Related issues and/or pull requests
Describe the changes you're proposing
fix : https://travis-ci.com/saltstack-formulas/bind-formula/jobs/269539556
Pillar / config required to test the proposed changes
test/salt/pillar/default.sls
Debug log showing how the proposed changes work
ID: bind Function: service.running Name: named Result: True Comment: Service named has been enabled, and is running Started: 10:37:50.288781 Duration: 751.513 ms Changes:
Documentation checklist
README
(e.g.Available states
).pillar.example
.Testing checklist
state_top
).Additional context