saltstack-formulas / bind-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
29 stars 117 forks source link

fix(default.sls):fix subnet declaration #144

Closed Irsute closed 4 years ago

Irsute commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

fix pillar for test (failling for named in FEDORA 30)

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

fix : https://travis-ci.com/saltstack-formulas/bind-formula/jobs/269539556

Pillar / config required to test the proposed changes

test/salt/pillar/default.sls

Debug log showing how the proposed changes work

ID: bind Function: service.running Name: named Result: True Comment: Service named has been enabled, and is running Started: 10:37:50.288781 Duration: 751.513 ms Changes:

          named:
              True

Documentation checklist

Testing checklist

Additional context

myii commented 4 years ago

@Irsute The Travis errors are unrelated to this PR, we've had a problem when using rubocop -a --safe. I'll get around to fixing that soon and then we can rebase this PR to confirm it is working.

myii commented 4 years ago

@Irsute I've added your commit from here in c814779, with slight amendments to pass the InSpec tests.